Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable perfsprint linter #11599

Merged

Conversation

mmorel-35
Copy link
Contributor

Description

perfsprint checks that fmt.Sprintf can be replaced with a faster alternative.

@mmorel-35 mmorel-35 requested a review from a team as a code owner November 5, 2024 06:48
@mmorel-35 mmorel-35 requested a review from codeboten November 5, 2024 06:48
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from d9b5e4b to 829b093 Compare November 5, 2024 06:56
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (084aa63) to head (829b093).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/otelchecker.go 0.00% 5 Missing ⚠️
cmd/mdatagen/internal/metadata.go 0.00% 2 Missing ⚠️
exporter/debugexporter/internal/normal/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11599   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         441      441           
  Lines       23848    23848           
=======================================
  Hits        21830    21830           
  Misses       1645     1645           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Nov 5, 2024
@bogdandrutu
Copy link
Member

@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from 829b093 to ff07b9a Compare November 5, 2024 18:59
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from ff07b9a to ead5111 Compare November 5, 2024 19:01
@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label Nov 5, 2024
@bogdandrutu bogdandrutu merged commit e053173 into open-telemetry:main Nov 5, 2024
64 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 5, 2024
@mmorel-35 mmorel-35 deleted the golangci-lint/perfsprint branch November 5, 2024 22:40
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
#### Description

[perfsprint](https://golangci-lint.run/usage/linters/#perfsprint) checks
that fmt.Sprintf can be replaced with a faster alternative.

Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants